Moves SQLitePersistentCookieStore to net/extras/sqlite.

content/browser/net/quota_policy_cookie_store.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// A cookie monster persistent store that deletes session cookies on shutdown.

[mef, 2015/05/12 21:23:27]

this comment seems out of date.

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

I believe this is correct.  The job of this class is to delete session cookies
on shutdown.

+
+#ifndef CONTENT_BROWSER_NET_QUOTA_POLICY_COOKIE_STORE_H_
+#define CONTENT_BROWSER_NET_QUOTA_POLICY_COOKIE_STORE_H_
+
+#include <string>
+#include <vector>
+
+#include "base/callback_forward.h"
+#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"

[Ryan Sleevi, 2015/05/12 00:48:33]

Unused

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Done.

+#include "content/common/content_export.h"
+#include "net/cookies/cookie_monster.h"
+#include "net/extras/sqlite/sqlite_persistent_cookie_store.h"

[Ryan Sleevi, 2015/05/12 00:48:33]

Strictly speaking, do you have to depend on the SQLite implementation? It seems
like we could get away with just depending on the CookieMonster if it had the
DeleteAll() method.

Just wondering out loud...

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Hmmm.  I think we could depend on a CookieMonster::PersistentCookieStore if we
added the DeleteAllInList() method.  It's maybe a weird API to force into that
interface?  I'm not going to make any changes in this CL, but it's an
interesting idea.

+
+class Task;
+
+namespace base {
+class FilePath;
+class SequencedTaskRunner;
+}

[Ryan Sleevi, 2015/05/12 00:48:33]

}  // namespace base

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Done.

+
+namespace net {
+class CanonicalCookie;
+class CookieCryptoDelegate;
+}

[Ryan Sleevi, 2015/05/12 00:48:33]

}  // namespace net

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Done.

+
+namespace storage {
+class SpecialStoragePolicy;
+}

[Ryan Sleevi, 2015/05/12 00:48:33]

}  // namespace storage

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Done.

+
+namespace content {
+
+// Implements a PersistentCookieStore that deletes session cookies on
+// shutdown. For documentation about the actual member functions consult the
+// parent class |net::CookieMonster::PersistentCookieStore|. If provided, a
+// |SpecialStoragePolicy| is consulted when the SQLite database is closed to
+// decide which cookies to keep.
+class CONTENT_EXPORT QuotaPolicyCookieStore
+    : public net::CookieMonster::PersistentCookieStore {
+ public:
+  // Wraps the passed-in |cookie_store|..

[Ryan Sleevi, 2015/05/12 00:48:34]

nit: extra . ?

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Done.

+  QuotaPolicyCookieStore(
+      scoped_refptr<net::SQLitePersistentCookieStore> cookie_store,

[Ryan Sleevi, 2015/05/12 00:48:33]

const-ref unless you want to force callers to .Pass(); prefer the former over
the latter.

[rohitrao (ping after 24h), 2015/05/13 17:05:07]

Done.

+      storage::SpecialStoragePolicy* special_storage_policy);
+
+  // net::CookieMonster::PersistentCookieStore:
+  void Load(const LoadedCallback& loaded_callback) override;
+  void LoadCookiesForKey(const std::string& key,
+                         const LoadedCallback& callback) override;
+  void AddCookie(const net::CanonicalCookie& cc) override;
+  void UpdateCookieAccessTime(const net::CanonicalCookie& cc) override;
+  void DeleteCookie(const net::CanonicalCookie& cc) override;
+  void SetForceKeepSessionState() override;
+  void Flush(const base::Closure& callback) override;
+
+ private:
+  typedef std::map<net::SQLitePersistentCookieStore::CookieOrigin, size_t>
+      CookiesPerOriginMap;
+
+  ~QuotaPolicyCookieStore() override;
+
+  // Called after cookies are loaded from the database.  Calls |loaded_callback|
+  // when done.
+  void OnLoad(const LoadedCallback& loaded_callback,
+              const std::vector<net::CanonicalCookie*>& cookies);
+
+  // Map of (domain keys(eTLD+1), is secure cookie) to number of cookies in the
+  // database.
+  CookiesPerOriginMap cookies_per_origin_;
+
+  scoped_refptr<storage::SpecialStoragePolicy> special_storage_policy_;
+  scoped_refptr<net::SQLitePersistentCookieStore> persistent_store_;
+
+  DISALLOW_COPY_AND_ASSIGN(QuotaPolicyCookieStore);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_NET_QUOTA_POLICY_COOKIE_STORE_H_