Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: remoting/webapp/base/js/application.js

Issue 1016623002: [Webapp Refactor] Reparent the ConnectedView into the delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Please diff this patch against patch set 1 Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/application.js
diff --git a/remoting/webapp/base/js/application.js b/remoting/webapp/base/js/application.js
index 008a277c430b2bf28d01aead41496baf2be083bd..82b64534c4a50a56a79271531acecc8fbb2c3b4e 100644
--- a/remoting/webapp/base/js/application.js
+++ b/remoting/webapp/base/js/application.js
@@ -159,31 +159,6 @@ remoting.Application.prototype.onVideoStreamingStarted = function() {
};
/**
- * Called when an extension message needs to be handled.
- *
- * @param {string} type The type of the extension message.
- * @param {string} data The payload of the extension message.
- * @return {boolean} Return true if the extension message was recognized.
- */
-remoting.Application.prototype.onExtensionMessage = function(type, data) {
- var message = /** @type {Object} */ (base.jsonParseSafe(data));
- if (typeof message != 'object') {
- return false;
- }
-
- // Give the delegate a chance to handle this extension message first.
- if (this.delegate_.handleExtensionMessage(type, message)) {
- return true;
- }
-
- if (remoting.desktopConnectedView) {
- return remoting.desktopConnectedView.handleExtensionMessage(type, message);
- }
-
- return false;
-};
-
-/**
* Called when an error needs to be displayed to the user.
*
* @param {!remoting.Error} errorTag The error to be localized and displayed.
@@ -204,7 +179,6 @@ remoting.Application.prototype.getSessionConnector = function() {
document.getElementById('client-container'),
this.onConnected.bind(this),
this.onError.bind(this),
- this.onExtensionMessage.bind(this),
this.onConnectionFailed.bind(this),
this.appCapabilities_,
this.delegate_.getDefaultRemapKeys());
@@ -334,16 +308,6 @@ remoting.Application.Delegate.prototype.handleVideoStreamingStarted =
function() {};
/**
- * Called when an extension message needs to be handled.
- *
- * @param {string} type The type of the extension message.
- * @param {Object} message The parsed extension message data.
- * @return {boolean} Return true if the extension message was recognized.
- */
-remoting.Application.Delegate.prototype.handleExtensionMessage =
- function(type, message) {};
-
-/**
* Called when an error needs to be displayed to the user.
*
* @param {!remoting.Error} errorTag The error to be localized and displayed.

Powered by Google App Engine
This is Rietveld 408576698