remoting/webapp/crd/js/session_connector.js - Issue 1016623002: [Webapp Refactor] Reparent the ConnectedView into the delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/session_connector.js

Issue 1016623002: [Webapp Refactor] Reparent the ConnectedView into the delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Baseline Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/crd/js/desktop_remoting.js ('K') | « remoting/webapp/crd/js/gnubby_auth_handler.js ('k') | remoting/webapp/crd/js/session_connector_impl.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/session_connector.js

diff --git a/remoting/webapp/crd/js/session_connector.js b/remoting/webapp/crd/js/session_connector.js

index 3da3f659c6bc6a8f9345c2eeadf0c24bfd026f13..fce0bef67ae31b20ad076918914a5a886ff950f2 100644

--- a/remoting/webapp/crd/js/session_connector.js

+++ b/remoting/webapp/crd/js/session_connector.js

@@ -121,9 +121,6 @@ remoting.SessionConnectorFactory = function() {};

* @param {function(remoting.ConnectionInfo):void} onConnected Callback on

* success.

* @param {function(!remoting.Error):void} onError Callback on error.

- * @param {function(string, string):boolean} appProtocolExtensionHandler The

- * handler for the application's protocol extension messages. Returns true

- * if a message is recognized; false otherwise.

* @param {function(!remoting.Error):void} onConnectionFailed Callback for when

* the connection fails.

* @param {Array<string>} requiredCapabilities Connector capabilities

@@ -133,7 +130,7 @@ remoting.SessionConnectorFactory = function() {};

* @return {remoting.SessionConnector}

remoting.SessionConnectorFactory.prototype.createConnector =

- function(clientContainer, onConnected, onError, appProtocolExtensionHandler,

+ function(clientContainer, onConnected, onError,

onConnectionFailed, requiredCapabilities, defaultRemapKeys) {};

/**