[Webapp Refactor] Reparent the ConnectedView into the delegate.

remoting/webapp/crd/js/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 369 matching lines @@
 /**
  * Callback that the plugin invokes to indicate that the connection
  * status has changed.
  *
  * @param {remoting.ClientSession.State} status The plugin's status.
  * @param {remoting.ClientSession.ConnectionError} error The plugin's error
  *        state, if any.
  */
 remoting.ClientSession.prototype.onConnectionStatusUpdate =
     function(status, error) {
-  if (status == remoting.ClientSession.State.CONNECTED) {
-    remoting.desktopConnectedView.onConnected();
-  } else if (status == remoting.ClientSession.State.FAILED) {
+  if (status == remoting.ClientSession.State.FAILED) {
     switch (error) {
       case remoting.ClientSession.ConnectionError.HOST_IS_OFFLINE:
         this.error_ = new remoting.Error(
             remoting.Error.Tag.HOST_IS_OFFLINE);
         break;
       case remoting.ClientSession.ConnectionError.SESSION_REJECTED:
         this.error_ = new remoting.Error(
             remoting.Error.Tag.INVALID_ACCESS_CODE);
         break;
       case remoting.ClientSession.ConnectionError.INCOMPATIBLE_PROTOCOL:
@@ skipping 40 matching lines @@
   // TODO(jamiewalch): Currently, the logic for determining whether or not the
   // connection is available is based solely on whether or not any video frames
   // have been received recently. which leads to poor UX on slow connections.
   // Re-enable this once crbug.com/435315 has been fixed.
   var ignoreVideoChannelState = true;
   if (ignoreVideoChannelState) {
     console.log('Video channel ' + (ready ? '' : 'not ') + 'ready.');
     return;
   }
 
-  remoting.desktopConnectedView.onConnectionReady(ready);

[kelvinp, 2015/03/17 01:06:16]

Implemented in DesktopConnectedView as an event instead.

-
   this.raiseEvent(remoting.ClientSession.Events.videoChannelStateChanged,
                   ready);
 };
 
 /**
  * Called when the client-host capabilities negotiation is complete.
  * TODO(kelvinp): Move this function out of ClientSession.
  *
  * @param {!Array<string>} capabilities The set of capabilities negotiated
  *     between the client and host.
  * @return {void} Nothing.
  * @private
  */
 remoting.ClientSession.prototype.onSetCapabilities = function(capabilities) {
   if (this.capabilities_ != null) {
     console.error('onSetCapabilities_() is called more than once');
     return;
   }
 
   this.capabilities_ = capabilities;
   if (this.hasCapability(remoting.ClientSession.Capability.GOOGLE_DRIVE)) {
     this.sendGoogleDriveAccessToken_();
   }
-  if (this.hasCapability(

[kelvinp, 2015/03/17 01:06:16]

Moved to DesktopConnectedView.

-      remoting.ClientSession.Capability.VIDEO_RECORDER)) {
-    remoting.desktopConnectedView.initVideoFrameRecorder();
-  }
 };
 
 /**
  * @param {string} type
  * @param {string} data
  */
 remoting.ClientSession.prototype.onExtensionMessage = function(type, data) {
   this.onExtensionMessageHandler_(type, data);
 };
 
@@ skipping 114 matching lines @@
   var sendError = function(error) {
     console.log('Failed to refresh access token: ' + error.toString());
   };
   remoting.identity.getNewToken().
       then(sendToken).
       catch(remoting.Error.handler(sendError));
   window.setTimeout(this.sendGoogleDriveAccessToken_.bind(this),
                     remoting.ACCESS_TOKEN_RESEND_INTERVAL_MS);
 };
 
-/**
- * Enables or disables rendering of dirty regions for debugging.
- * @param {boolean} enable True to enable rendering.
- */
-remoting.ClientSession.prototype.enableDebugRegion = function(enable) {

[kelvinp, 2015/03/17 01:06:17]

Moved to ConnectedView.

-  if (enable) {
-    this.plugin_.setDebugDirtyRegionHandler(
-        remoting.desktopConnectedView.handleDebugRegion.bind(
-            remoting.desktopConnectedView));
-  } else {
-    this.plugin_.setDebugDirtyRegionHandler(null);
-  }
-}