Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1016613005: Files.app: Avoid triggering spurious errors on cloud import cancellation. (Closed)

Created:
5 years, 9 months ago by Ben Kwa
Modified:
5 years, 9 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Avoid triggering spurious errors on cloud import cancellation. Cancelling an import will result in abort errors for in-flight copy operations. We don't care about these errors because they're expected, so trap and ignore them. This fixes a bug where the uncaught exceptions were preventing the UI from being updated. BUG=469855 Committed: https://crrev.com/86ffe2c8cef83afac99a842492595cd997cd100a Cr-Commit-Position: refs/heads/master@{#321860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M ui/file_manager/file_manager/background/js/media_import_handler.js View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Kwa
5 years, 9 months ago (2015-03-23 20:31:37 UTC) #2
Steve McKay
lgtm
5 years, 9 months ago (2015-03-23 20:59:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016613005/1
5 years, 9 months ago (2015-03-23 20:59:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 21:36:05 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:37:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86ffe2c8cef83afac99a842492595cd997cd100a
Cr-Commit-Position: refs/heads/master@{#321860}

Powered by Google App Engine
This is Rietveld 408576698