Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: testing/tools/run_corpus_tests.py

Issue 1016613004: Create simple suppressions file in PDFium repository. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/SUPPRESSIONS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/tools/run_corpus_tests.py
diff --git a/testing/tools/run_corpus_tests.py b/testing/tools/run_corpus_tests.py
index 2f6de0721252cd8917be532848b0e8d64958b693..2452cda7e665a598c71eee4720fac2f45df5a34d 100755
--- a/testing/tools/run_corpus_tests.py
+++ b/testing/tools/run_corpus_tests.py
@@ -84,6 +84,9 @@ def main():
if not os.path.exists(working_dir):
os.makedirs(working_dir)
+ with open(os.path.join(testing_dir, 'SUPPRESSIONS')) as f:
+ suppression_list = map(lambda x: x.strip(), f.readlines())
Lei Zhang 2015/03/23 19:00:30 I think list comprehensions are more common than m
Tom Sepez 2015/03/23 19:21:23 Done.
+
# test files are under .../pdfium/testing/corpus.
os_exit_code = 0
walk_from_dir = os.path.join(testing_dir, 'corpus');
@@ -93,7 +96,10 @@ def main():
if input_file_re.match(input_filename):
input_path = os.path.join(source_dir, input_filename)
if os.path.isfile(input_path):
- if not test_one_file(input_filename, source_dir, working_dir,
+ if input_filename in suppression_list:
+ print "Not running %s, found in SUPPRESSIONS file" % input_filename
+ continue
+ if not test_one_file(input_filename, source_dir, working_dir,
pdfium_test_path, pdfium_diff_path):
os_exit_code = 1
« no previous file with comments | « testing/SUPPRESSIONS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698