Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1016613004: Create simple suppressions file in PDFium repository. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create simple suppressions file in PDFium repository. This is needed to green the tree without continually reverting the pdfium_tests (corpus) repository. We will need to make this more sophisticated at some point, but for now, let's try to green the buildbot. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/97c87e787710ee9ca5261eab928295db09c23024

Patch Set 1 #

Total comments: 2

Patch Set 2 : List Comprehensions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
A testing/SUPPRESSIONS View 1 chunk +46 lines, -0 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Lei, for review.
5 years, 9 months ago (2015-03-23 17:43:56 UTC) #1
Lei Zhang
lgtm for now. The suppressions parsing really should support # comments and blank lines. https://codereview.chromium.org/1016613004/diff/1/testing/tools/run_corpus_tests.py ...
5 years, 9 months ago (2015-03-23 19:00:30 UTC) #2
Tom Sepez
https://codereview.chromium.org/1016613004/diff/1/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1016613004/diff/1/testing/tools/run_corpus_tests.py#newcode88 testing/tools/run_corpus_tests.py:88: suppression_list = map(lambda x: x.strip(), f.readlines()) On 2015/03/23 19:00:30, ...
5 years, 9 months ago (2015-03-23 19:21:23 UTC) #3
Tom Sepez
5 years, 9 months ago (2015-03-23 19:27:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
97c87e787710ee9ca5261eab928295db09c23024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698