Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1016603006: Force Mac editing behavior for fast/multicol/hit-test-above-or-below.html (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 9 months ago
CC:
blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Force Mac editing behavior for fast/multicol/hit-test-above-or-below.html This way we won't need platform specific expectations, since it should now just pass on all platforms. What to hit when you start selecting below the end of the last column (or simply below the block in non-multicol), is platform-specific. On Windows you hit the character that's directly above the cursor, while on Linux and Mac you hit the end of the text. This is another preparatory patch for enabling region based columns. R=jchaffraix@chromium.org BUG=334335 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M LayoutTests/fast/multicol/hit-test-above-or-below.html View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/hit-test-above-or-below-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-26 17:19:10 UTC) #1
eae
LGTM
5 years, 9 months ago (2015-03-26 21:08:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016603006/1
5 years, 9 months ago (2015-03-26 21:17:41 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 22:33:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192632

Powered by Google App Engine
This is Rietveld 408576698