base/profiler/stack_sampling_profiler_posix.cc - Issue 1016563004: Statistical stack profiler for Windows x64

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/profiler/stack_sampling_profiler_posix.cc

Issue 1016563004: Statistical stack profiler for Windows x64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/profiler/stack_sampling_profiler.h"

	6

	7 namespace base {

	8

	9 scoped_ptr<StackSamplingProfiler::NativeStackSampler>

	10 StackSamplingProfiler::NativeStackSampler::Create(
	Alexei Svitkine (slow) 2015/03/17 13:10:00 I think for cases like these, convention is not to I think for cases like these, convention is not to indent here. Perhaps just run "git cl format"? (Or did it produce this indentation?) Mike Wittman 2015/03/17 19:07:38 Yes, that's correct. Unindented. Show quoted text On 2015/03/17 13:10:00, Alexei Svitkine (away) wrote: > I think for cases like these, convention is not to indent here. Perhaps just run > "git cl format"? (Or did it produce this indentation?) Yes, that's correct. Unindented.
	11 PlatformThreadId thread_id) {

	12 return scoped_ptr<NativeStackSampler>();

	13 }

	14

	15 }
	Alexei Svitkine (slow) 2015/03/17 13:10:00 Nit: // base Nit: // base Mike Wittman 2015/03/17 19:07:38 Done. Show quoted text On 2015/03/17 13:10:00, Alexei Svitkine (away) wrote: > Nit: // base Done.
OLD	NEW