Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1016553003: Remove MIME type check for pre-ICS Android. (Closed)

Created:
5 years, 9 months ago by ddorwin
Modified:
5 years, 9 months ago
Reviewers:
qinmin, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MIME type check for pre-ICS Android. Pre-ICS Android is not supported. Committed: https://crrev.com/b42007a5d3295ab0d12547af1615cf785204587f Cr-Commit-Position: refs/heads/master@{#320970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M net/base/mime_util.cc View 4 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ddorwin
Small code removal.
5 years, 9 months ago (2015-03-17 00:01:07 UTC) #2
qinmin
lgtm
5 years, 9 months ago (2015-03-17 18:05:32 UTC) #3
ddorwin
rsleevi: please OWNERS review this simple code removal (less code to move later!)
5 years, 9 months ago (2015-03-17 18:09:23 UTC) #5
Ryan Sleevi
LGTM, but is there a general "remove ICS code" bug to staple this to?
5 years, 9 months ago (2015-03-17 18:37:11 UTC) #6
ddorwin
On 2015/03/17 18:37:11, Ryan Sleevi wrote: > LGTM, but is there a general "remove ICS ...
5 years, 9 months ago (2015-03-17 19:56:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016553003/1
5 years, 9 months ago (2015-03-17 19:56:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 21:06:06 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:06:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b42007a5d3295ab0d12547af1615cf785204587f
Cr-Commit-Position: refs/heads/master@{#320970}

Powered by Google App Engine
This is Rietveld 408576698