Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/common/mac/app_mode_common.mm

Issue 1016543004: [Mac] Use the app's version as the app shim bundle version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use GetVersionForDisplay. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/mac/app_mode_common.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/mac/app_mode_common.h" 5 #include "chrome/common/mac/app_mode_common.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 8
9 namespace app_mode { 9 namespace app_mode {
10 10
(...skipping 13 matching lines...) Expand all
24 NSString* const kCFBundleDocumentTypesKey = @"CFBundleDocumentTypes"; 24 NSString* const kCFBundleDocumentTypesKey = @"CFBundleDocumentTypes";
25 NSString* const kCFBundleTypeExtensionsKey = @"CFBundleTypeExtensions"; 25 NSString* const kCFBundleTypeExtensionsKey = @"CFBundleTypeExtensions";
26 NSString* const kCFBundleTypeIconFileKey = @"CFBundleTypeIconFile"; 26 NSString* const kCFBundleTypeIconFileKey = @"CFBundleTypeIconFile";
27 NSString* const kCFBundleTypeNameKey = @"CFBundleTypeName"; 27 NSString* const kCFBundleTypeNameKey = @"CFBundleTypeName";
28 NSString* const kCFBundleTypeMIMETypesKey = @"CFBundleTypeMIMETypes"; 28 NSString* const kCFBundleTypeMIMETypesKey = @"CFBundleTypeMIMETypes";
29 NSString* const kCFBundleTypeRoleKey = @"CFBundleTypeRole"; 29 NSString* const kCFBundleTypeRoleKey = @"CFBundleTypeRole";
30 NSString* const kBundleTypeRoleViewer = @"Viewer"; 30 NSString* const kBundleTypeRoleViewer = @"Viewer";
31 31
32 NSString* const kCFBundleDisplayNameKey = @"CFBundleDisplayName"; 32 NSString* const kCFBundleDisplayNameKey = @"CFBundleDisplayName";
33 NSString* const kCFBundleShortVersionStringKey = @"CFBundleShortVersionString"; 33 NSString* const kCFBundleShortVersionStringKey = @"CFBundleShortVersionString";
34 NSString* const kCrBundleVersionKey = @"CrBundleVersion";
34 NSString* const kLSHasLocalizedDisplayNameKey = @"LSHasLocalizedDisplayName"; 35 NSString* const kLSHasLocalizedDisplayNameKey = @"LSHasLocalizedDisplayName";
35 NSString* const kBrowserBundleIDKey = @"CrBundleIdentifier"; 36 NSString* const kBrowserBundleIDKey = @"CrBundleIdentifier";
36 NSString* const kCrAppModeShortcutIDKey = @"CrAppModeShortcutID"; 37 NSString* const kCrAppModeShortcutIDKey = @"CrAppModeShortcutID";
37 NSString* const kCrAppModeShortcutNameKey = @"CrAppModeShortcutName"; 38 NSString* const kCrAppModeShortcutNameKey = @"CrAppModeShortcutName";
38 NSString* const kCrAppModeShortcutURLKey = @"CrAppModeShortcutURL"; 39 NSString* const kCrAppModeShortcutURLKey = @"CrAppModeShortcutURL";
39 NSString* const kCrAppModeUserDataDirKey = @"CrAppModeUserDataDir"; 40 NSString* const kCrAppModeUserDataDirKey = @"CrAppModeUserDataDir";
40 NSString* const kCrAppModeProfileDirKey = @"CrAppModeProfileDir"; 41 NSString* const kCrAppModeProfileDirKey = @"CrAppModeProfileDir";
41 NSString* const kCrAppModeProfileNameKey = @"CrAppModeProfileName"; 42 NSString* const kCrAppModeProfileNameKey = @"CrAppModeProfileName";
42 43
43 NSString* const kLastRunAppBundlePathPrefsKey = @"LastRunAppBundlePath"; 44 NSString* const kLastRunAppBundlePathPrefsKey = @"LastRunAppBundlePath";
(...skipping 16 matching lines...) Expand all
60 61
61 void VerifySocketPermissions(const base::FilePath& socket_path) { 62 void VerifySocketPermissions(const base::FilePath& socket_path) {
62 CHECK(base::PathIsWritable(socket_path)); 63 CHECK(base::PathIsWritable(socket_path));
63 base::FilePath socket_dir = socket_path.DirName(); 64 base::FilePath socket_dir = socket_path.DirName();
64 int socket_dir_mode = 0; 65 int socket_dir_mode = 0;
65 CHECK(base::GetPosixFilePermissions(socket_dir, &socket_dir_mode)); 66 CHECK(base::GetPosixFilePermissions(socket_dir, &socket_dir_mode));
66 CHECK_EQ(0700, socket_dir_mode); 67 CHECK_EQ(0700, socket_dir_mode);
67 } 68 }
68 69
69 } // namespace app_mode 70 } // namespace app_mode
OLDNEW
« no previous file with comments | « chrome/common/mac/app_mode_common.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698