[Mac] Use the app's version as the app shim bundle version.

chrome/common/mac/app_mode_chrome_locator.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/common/mac/app_mode_chrome_locator.h"
 
 #import <AppKit/AppKit.h>
 #include <CoreFoundation/CoreFoundation.h>
 
 #include "base/files/file_path.h"
@@ skipping 36 matching lines @@
   NSString* cr_versioned_path;
   if (!version_str.empty()) {
     cr_versioned_path =
         GetVersionedPath(cr_bundle_path, base::SysUTF8ToNSString(version_str));
   }
 
   if (version_str.empty() ||
       !base::PathExists(base::mac::NSStringToFilePath(cr_versioned_path))) {
     // Read version string.
     NSString* cr_version = ObjCCast<NSString>(
-        [cr_bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"]);
+        [cr_bundle objectForInfoDictionaryKey:@"CrBundleVersion"]);

[tapted, 2015/03/18 01:49:59]

kCrBundleVersionKey?

Although I guess that's not linked here. If that's not easy to do, can we
instead pull it out to declared constant at the top of the file, with a comment
saying it comes from app_mode_common.mm and why it's not just #included.

[jackhou1, 2015/03/18 04:43:48]

Done.

+    if (!cr_version) {
+      // Older bundles have the Chrome version in the following key.
+      cr_version = ObjCCast<NSString>(
+          [cr_bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"]);
+    }
     if (!cr_version)
       return false;
 
     cr_versioned_path = GetVersionedPath(cr_bundle_path, cr_version);
   }
 
   // Get the framework path.
   NSString* cr_bundle_exe =
       ObjCCast<NSString>(
           [cr_bundle objectForInfoDictionaryKey:@"CFBundleExecutable"]);
@@ skipping 29 matching lines @@
 
   // Everything OK, copy output parameters.
   *executable_path = base::mac::NSStringToFilePath([cr_bundle executablePath]);
   *version_path = base::mac::NSStringToFilePath(cr_versioned_path);
   *framework_shlib_path =
       base::mac::NSStringToFilePath(cr_framework_shlib_path);
   return true;
 }
 
 }  // namespace app_mode