Remove GetDefaultProfile from various Android related code

Remove GetDefaultProfile from various Android related code

Trying to get rid of GetDefaultProfile since it was depricated since 2011. See https://docs.google.com/a/google.com/document/d/1Fo0_ixnmOYDZKjcdzU3btED3yWINpdBvzpgl7EBOZro/edit#heading=h.5pkgd9yd16w5 for more informations!

BUG=322682
TEST=covered by existing unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243456

[Mr4D (OOO till 08-26), 2013-12-20 21:48:52]

Please have a look!

[Mr4D (OOO till 08-26), 2013-12-20 21:51:55]

+yfriedman: Changed reviewers - that way there is a slim chance that we can do
this this year :)

[Evan Stade, 2013-12-20 22:46:31]

-estade, +aruslan

[aruslan, 2013-12-20 23:31:07]

LGTM -- it looks like a safe replacement given that GetUserActiveProfile() ==
GetDefaultProfile() on a non-ChromeOS platforms.
Thanks!

[Yaron, 2014-01-06 17:26:23]

lgtm

[Yaron, 2014-01-06 22:00:17]

https://codereview.chromium.org/101653006/diff/1/chrome/browser/android/signi...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/101653006/diff/1/chrome/browser/android/signi...
chrome/browser/android/signin/signin_manager_android.cc:77:
DCHECK(g_browser_process);
Actually can you drop these two DCHECKs. They seem out of place now.

[Mr4D (OOO till 08-26), 2014-01-07 17:12:14]

Addressed. It appears that I need another owners review. Estade - could you
please have a look?

Many thanks in advance!

https://codereview.chromium.org/101653006/diff/1/chrome/browser/android/signi...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/101653006/diff/1/chrome/browser/android/signi...
chrome/browser/android/signin/signin_manager_android.cc:77:
DCHECK(g_browser_process);
On 2014/01/06 22:00:17, Yaron wrote:
> Actually can you drop these two DCHECKs. They seem out of place now.

Done.

[Evan Stade, 2014-01-07 20:25:07]

lgtm

[commit-bot: I haz the power, 2014-01-07 21:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/101653006/110001

[commit-bot: I haz the power, 2014-01-07 22:57:11]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-07 22:59:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/101653006/110001

[commit-bot: I haz the power, 2014-01-08 01:10:06]

Change committed as 243456