Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1016483006: Hotword: Only run the Audio History callback with 'success' if there is a valid response (Closed)

Created:
5 years, 9 months ago by kcarattini
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hotword: Only run the Audio History callback with 'success' if there is a valid response BUG=466378 Committed: https://crrev.com/e729dfe8610352dcdbb4a43dd9a6c88a5fa4ba34 Cr-Commit-Position: refs/heads/master@{#320834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/history/core/browser/web_history_service.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kcarattini
sky@: Please review for OWNERS approval.
5 years, 9 months ago (2015-03-16 23:02:57 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-16 23:20:39 UTC) #3
Anand Mistry (off Chromium)
lgtm
5 years, 9 months ago (2015-03-16 23:24:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016483006/1
5 years, 9 months ago (2015-03-16 23:26:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 00:53:33 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 00:54:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e729dfe8610352dcdbb4a43dd9a6c88a5fa4ba34
Cr-Commit-Position: refs/heads/master@{#320834}

Powered by Google App Engine
This is Rietveld 408576698