Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1016483002: Don't attempt playback if not possible (Closed)

Created:
5 years, 9 months ago by jrummell
Modified:
5 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't attempt playback if not possible Some key systems aren't supported on all platforms, so don't try the multiple playback tests in those cases. BUG=467505 TEST=EncryptedMediaTests pass Committed: https://crrev.com/d9dc790dc2066fd61313d137b405b017dabe969c Cr-Commit-Position: refs/heads/master@{#320792}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jrummell
PTAL.
5 years, 9 months ago (2015-03-16 19:01:35 UTC) #2
ddorwin
https://codereview.chromium.org/1016483002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc File chrome/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/1016483002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc#newcode419 chrome/browser/media/encrypted_media_browsertest.cc:419: // TestSimplePlayback() checks for KEY_ERROR if playback is not ...
5 years, 9 months ago (2015-03-16 19:17:47 UTC) #3
jrummell
Updated. https://codereview.chromium.org/1016483002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc File chrome/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/1016483002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc#newcode419 chrome/browser/media/encrypted_media_browsertest.cc:419: // TestSimplePlayback() checks for KEY_ERROR if playback is ...
5 years, 9 months ago (2015-03-16 20:13:06 UTC) #4
ddorwin
lgtm Thanks.
5 years, 9 months ago (2015-03-16 20:26:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016483002/20001
5 years, 9 months ago (2015-03-16 20:28:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 20:59:36 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 21:00:13 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9dc790dc2066fd61313d137b405b017dabe969c
Cr-Commit-Position: refs/heads/master@{#320792}

Powered by Google App Engine
This is Rietveld 408576698