chrome/browser/extensions/extension_messages_apitest.cc - Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/extension_view_host.cc » ('j') | extensions/browser/extension_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_messages_apitest.cc

diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc

index dbf6b80098ef4313f59187b28a3deac7d4edf4d5..19c5b20fee0bace8257e088834696c253a0ae4d7 100644

--- a/chrome/browser/extensions/extension_messages_apitest.cc

+++ b/chrome/browser/extensions/extension_messages_apitest.cc

@@ -49,7 +49,7 @@ class MessageSender : public content::NotificationObserver {

public:

MessageSender() {

registrar_.Add(this,

- extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,

+ extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,

content::NotificationService::AllSources());

}

@@ -77,7 +77,8 @@ class MessageSender : public content::NotificationObserver {

void Observe(int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) override {

- DCHECK_EQ(extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING, type);

+ DCHECK_EQ(extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,

+ type);

EventRouter* event_router =

EventRouter::Get(content::Source<Profile>(source).ptr());