Issue 1016443003: Revert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://coderevi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1016443003: Revert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://coderevi… (Closed)

Created:
5 years, 9 months ago by msarett

Modified:
5 years, 9 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/)" This reverts commit d18475854ce232de71c5463e0654f459d4abfd43. Revert "Revert "Implementation of image decoding for bmp files, in accordance with the new API."" This reverts commit dfdec78a5d02e8690998741a9fe5b71a08ca3232. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/741143878b23d22cd9cb7b9cba8055179115ce17

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2035 lines, -109 lines)			Patch
M	dm/DMSrcSink.cpp	View	1 chunk	+20 lines, -8 lines	0 comments	Download
M	gyp/codec.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	include/codec/SkCodec.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/codec/SkCodec.cpp	View	1 chunk	+20 lines, -10 lines	0 comments	Download
A	src/codec/SkCodecPriv.h	View	1 chunk	+117 lines, -0 lines	0 comments	Download
A	src/codec/SkCodec_libbmp.h	View	1 chunk	+142 lines, -0 lines	0 comments	Download
A	src/codec/SkCodec_libbmp.cpp	View	1 chunk	+903 lines, -0 lines	0 comments	Download
M	src/codec/SkCodec_libpng.cpp	View	4 chunks	+3 lines, -6 lines	0 comments	Download
A	src/codec/SkMaskSwizzler.h	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	src/codec/SkMaskSwizzler.cpp	View	1 chunk	+205 lines, -0 lines	0 comments	Download
A	src/codec/SkMasks.h	View	1 chunk	+81 lines, -0 lines	0 comments	Download
A	src/codec/SkMasks.cpp	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	src/codec/SkSwizzler.h	View	2 chunks	+123 lines, -24 lines	0 comments	Download
M	src/codec/SkSwizzler.cpp	View	4 chunks	+189 lines, -61 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016443003/1

5 years, 9 months ago (2015-03-16 18:47:33 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 18:55:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/741143878b23d22cd9cb7b9cba8055179115ce17