Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 101643006: Add base:: to a string16 in printing/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
dpapad
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M printing/printing_context_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Dan Beam
7 years ago (2013-12-19 05:11:00 UTC) #1
dpapad
lgtm
7 years ago (2013-12-19 15:59:39 UTC) #2
dpapad
lgtm
7 years ago (2013-12-19 15:59:41 UTC) #3
dpapad
lgtm
7 years ago (2013-12-19 15:59:59 UTC) #4
Dan Beam
Looks really really good to you?!
7 years ago (2013-12-19 17:27:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/101643006/1
7 years ago (2013-12-19 17:28:27 UTC) #6
dpapad
On 2013/12/19 17:28:27, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years ago (2013-12-19 17:36:06 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
7 years ago (2013-12-19 20:30:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/101643006/1
7 years ago (2013-12-19 20:37:29 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-19 23:28:09 UTC) #10
Message was sent while issue was closed.
Change committed as 241974

Powered by Google App Engine
This is Rietveld 408576698