chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 1016413004: [Extensions] Update Error Console UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 1016413004: [Extensions] Update Error Console UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index dc6f19587681592813ad83a85a5530ae2c3b6cff..4d718918878cf5cd37e1d615f6b8dacc5e57b852 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -246,18 +246,15 @@ void ExtensionSettingsHandler::GetLocalizedValues(

l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_ERROR_TITLE));

// Extension Error and Extension Error Overlay:

+ source->AddString("extensionErrorHeading",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_HEADING));

+ source->AddString("extensionErrorClearAll",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_CLEAR_ALL));

+ source->AddString("extensionErrorNoErrors",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_NO_ERRORS));

source->AddString(

- "extensionErrorsShowMore",

- l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERRORS_SHOW_MORE));

- source->AddString(

- "extensionErrorsShowFewer",

- l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERRORS_SHOW_FEWER));

- source->AddString(

- "extensionErrorViewDetails",

- l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_VIEW_DETAILS));

- source->AddString(

- "extensionErrorViewManifest",

- l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_VIEW_MANIFEST));

+ "extensionErrorNoErrorsCodeMessage",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_NO_ERRORS_CODE_MESSAGE));

source->AddString("extensionErrorOverlayDone",

l10n_util::GetStringUTF16(IDS_DONE));

source->AddString(