chrome/browser/extensions/api/developer_private/extension_info_generator.cc - Issue 1016413004: [Extensions] Update Error Console UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Issue 1016413004: [Extensions] Update Error Console UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/extension_info_generator.h ('k') | chrome/browser/extensions/error_console/error_console.h » ('j') | chrome/browser/resources/extensions/extension_error.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

index 9ac1c437bb94dda7831f2e83e532ffccd3081125..52399fd36894d2f862928edd345e77b5fa0fcee6 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

@@ -79,6 +79,7 @@ void PopulateErrorBase(const ExtensionError& error, ErrorType* out) {

out->from_incognito = error.from_incognito();

out->source = base::UTF16ToUTF8(error.source());

out->message = base::UTF16ToUTF8(error.message());

+ out->id = error.id();

}

// Given a ManifestError object, converts it into its developer_private