Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1016413002: Fix wrench menu spacing regression (Closed)

Created:
5 years, 9 months ago by Andre
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@wrench-menu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrench menu spacing regression Fix a mistake I made in http://crrev.com/1003853004. Before that CL, the "More tools" submenu was incorrectly using IDC_ZOOM_MENU command, and I fixed that. But then I incorrectly added checks for IDC_MORE_TOOLS_MENU wherever it was checking for IDC_ZOOM_MINUS, causing this incorrect spacing bug. This removes those checks, but we still need a check to make sure it is enabled, because when it was incorrectly using IDC_ZOOM_MENU, it was getting enabled by BrowserCommandController. BUG=468644 Committed: https://crrev.com/24ac1f518e765a9f07310123b98df4329ed845f2 Cr-Commit-Position: refs/heads/master@{#321413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
sky@ PTAL.
5 years, 9 months ago (2015-03-19 17:43:26 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-19 19:29:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016413002/1
5 years, 9 months ago (2015-03-19 19:50:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 19:54:16 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:55:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24ac1f518e765a9f07310123b98df4329ed845f2
Cr-Commit-Position: refs/heads/master@{#321413}

Powered by Google App Engine
This is Rietveld 408576698