Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: Source/core/loader/BeaconLoader.cpp

Issue 1016373002: Perform CORS access checks on Beacon redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased + add mixed content test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/BeaconLoader.h ('k') | Source/core/loader/PingLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/BeaconLoader.cpp
diff --git a/Source/core/loader/BeaconLoader.cpp b/Source/core/loader/BeaconLoader.cpp
index 9da8f662917f0bbb6180abd6a6ca799a07f64633..35b056c4531ef9356c2ca410966587108784dc8e 100644
--- a/Source/core/loader/BeaconLoader.cpp
+++ b/Source/core/loader/BeaconLoader.cpp
@@ -7,12 +7,17 @@
#include "core/dom/DOMArrayBufferView.h"
#include "core/dom/Document.h"
+#include "core/fetch/CrossOriginAccessControl.h"
#include "core/fetch/FetchContext.h"
#include "core/fetch/FetchInitiatorTypeNames.h"
#include "core/fetch/ResourceFetcher.h"
#include "core/fileapi/File.h"
#include "core/frame/LocalFrame.h"
#include "core/html/DOMFormData.h"
+#include "core/inspector/ConsoleMessage.h"
+#include "core/loader/MixedContentChecker.h"
+#include "platform/exported/WrappedResourceRequest.h"
+#include "platform/exported/WrappedResourceResponse.h"
#include "platform/network/FormData.h"
#include "platform/network/ParsedContentType.h"
#include "platform/network/ResourceRequest.h"
@@ -68,6 +73,9 @@ class BeaconLoader::Sender {
public:
static bool send(LocalFrame* frame, int allowance, const KURL& beaconURL, const Beacon& beacon, int& payloadLength)
{
+ if (!frame->document())
+ return false;
+
unsigned long long entitySize = beacon.size();
if (allowance > 0 && static_cast<unsigned long long>(allowance) < entitySize)
return false;
@@ -80,6 +88,9 @@ public:
frame->document()->fetcher()->context().addAdditionalRequestHeaders(request, FetchSubresource);
frame->document()->fetcher()->context().setFirstPartyForCookies(request);
+ if (MixedContentChecker::shouldBlockFetch(frame, request, request.url()))
+ return false;
+
payloadLength = entitySize;
if (!beacon.serialize(request, allowance, payloadLength))
return false;
@@ -87,7 +98,9 @@ public:
FetchInitiatorInfo initiatorInfo;
initiatorInfo.name = FetchInitiatorTypeNames::beacon;
- PingLoader::start(frame, request, initiatorInfo);
+ // Leak the loader, since it will kill itself as soon as it receives a response.
+ RefPtrWillBeRawPtr<BeaconLoader> loader = adoptRefWillBeNoop(new BeaconLoader(frame, request, initiatorInfo, AllowStoredCredentials));
+ loader->ref();
return true;
}
};
@@ -116,6 +129,40 @@ bool BeaconLoader::sendBeacon(LocalFrame* frame, int allowance, const KURL& beac
return Sender::send(frame, allowance, beaconURL, beacon, payloadLength);
}
+BeaconLoader::BeaconLoader(LocalFrame* frame, ResourceRequest& request, const FetchInitiatorInfo& initiatorInfo, StoredCredentials credentialsAllowed)
+ : PingLoader(frame, request, initiatorInfo, credentialsAllowed)
+ , m_beaconOrigin(frame->document()->securityOrigin())
+{
+}
+
+void BeaconLoader::willSendRequest(WebURLLoader*, WebURLRequest& passedNewRequest, const WebURLResponse& passedRedirectResponse)
+{
+ passedNewRequest.setAllowStoredCredentials(true);
+ ResourceRequest& newRequest(passedNewRequest.toMutableResourceRequest());
+ const ResourceResponse& redirectResponse(passedRedirectResponse.toResourceResponse());
+
+ ASSERT(!newRequest.isNull());
+ ASSERT(!redirectResponse.isNull());
+
+ String errorDescription;
+ StoredCredentials withCredentials = AllowStoredCredentials;
+ ResourceLoaderOptions options;
+ if (!CrossOriginAccessControl::handleRedirect(m_beaconOrigin.get(), newRequest, redirectResponse, withCredentials, options, errorDescription)) {
+ if (page() && page()->mainFrame()) {
+ if (page()->mainFrame()->isLocalFrame()) {
+ LocalFrame* localFrame = toLocalFrame(page()->mainFrame());
+ if (localFrame->document())
+ localFrame->document()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorDescription));
+ }
+ }
+ // Cancel the load and self destruct.
+ dispose();
+ return;
+ }
+ // FIXME: http://crbug.com/427429 is needed to correctly propagate
+ // updates of Origin: following this successful redirect.
+}
+
namespace {
unsigned long long Beacon::beaconSize(const String& data)
« no previous file with comments | « Source/core/loader/BeaconLoader.h ('k') | Source/core/loader/PingLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698