Source/core/loader/PingLoader.h - Issue 1016373002: Perform CORS access checks on Beacon redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/PingLoader.h

Issue 1016373002: Perform CORS access checks on Beacon redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/PingLoader.h

diff --git a/Source/core/loader/PingLoader.h b/Source/core/loader/PingLoader.h

index fb4f506aeee12f698ad427339777c361c0662c48..69f5da59a5f4e9783b7c7d416f317b9447425610 100644

--- a/Source/core/loader/PingLoader.h

+++ b/Source/core/loader/PingLoader.h

@@ -79,6 +79,8 @@ protected:

static void start(LocalFrame*, ResourceRequest&, const FetchInitiatorInfo&, StoredCredentials = AllowStoredCredentials);

+ void dispose();

private:

virtual void didReceiveResponse(blink::WebURLLoader*, const blink::WebURLResponse&) override;

virtual void didReceiveData(blink::WebURLLoader*, const char*, int, int) override;

@@ -89,8 +91,6 @@ private:

void didFailLoading(Page*);

- void dispose();

OwnPtr<blink::WebURLLoader> m_loader;

Timer<PingLoader> m_timeout;

String m_url;