Source/core/fetch/CrossOriginAccessControl.h - Issue 1016373002: Perform CORS access checks on Beacon redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/CrossOriginAccessControl.h

Issue 1016373002: Perform CORS access checks on Beacon redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/navigation/beacon-cross-origin-redirect.html ('K') | « LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-expected.txt ('k') | Source/core/fetch/CrossOriginAccessControl.cpp » ('j') | Source/core/loader/BeaconLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fetch/CrossOriginAccessControl.h

diff --git a/Source/core/fetch/CrossOriginAccessControl.h b/Source/core/fetch/CrossOriginAccessControl.h

index a5b3433053bb7a5782813e353229365be8ea93a2..aea4af23b8632302a4cc61d91a40a7a6e683add7 100644

--- a/Source/core/fetch/CrossOriginAccessControl.h

+++ b/Source/core/fetch/CrossOriginAccessControl.h

@@ -46,7 +46,7 @@ class SecurityOrigin;

class CrossOriginAccessControl {

public:

static bool isLegalRedirectLocation(const KURL&, String& errorDescription);

- static bool handleRedirect(ExecutionContext*, Resource*, SecurityOrigin*, ResourceRequest&, const ResourceResponse&, ResourceLoaderOptions&, String&);

+ static bool handleRedirect(ExecutionContext*, SecurityOrigin*, ResourceRequest&, const ResourceResponse&, StoredCredentials, ResourceLoaderOptions&, String&);

};

bool isOnAccessControlResponseHeaderWhitelist(const String&);