Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1016343002: Remove now-unused uniqueID param from SkDropShadowImageFilter::Create(). (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove now-unused uniqueID param from SkDropShadowImageFilter::Create(). Also make both input & crop rect default NULL, as in other filter Create functions. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6c1b3388275ab30c26ef0cd1ff21076fab0888a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M include/effects/SkDropShadowImageFilter.h View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Stephen White
PTAL
5 years, 9 months ago (2015-03-19 14:39:48 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-19 16:51:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016343002/1
5 years, 9 months ago (2015-03-19 18:57:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016343002/1
5 years, 9 months ago (2015-03-19 20:39:13 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 20:39:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6c1b3388275ab30c26ef0cd1ff21076fab0888a5

Powered by Google App Engine
This is Rietveld 408576698