Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1016333002: PPC: Remove kind field from StackHandler. (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove kind field from StackHandler. Port 15f8213809a57c2a163b500a732c9ffe5160a41a Original commit message: This relands commit 96f79568a926966ebcf0685bf9adc947f4e1fbff. This makes the Isolate::Throw logic not depend on a prediction of whether an exception is caught or uncaught. Such a prediction is inherently undecidable because a finally block can decide between consuming or re-throwing an exception depending on arbitray control flow. There still is a conservative prediction mechanism in place that components like the debugger or tracing can use for reporting. With this change we can get rid of the StackHandler::kind field, a pre-requisite to do table-based lookups of exception handlers. R=mbrandy@us.ibm.com, yangguo@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/890c0eac21919a08ae10782ec3cc40d1381cbd8b Cr-Commit-Position: refs/heads/master@{#27381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/ppc/macro-assembler-ppc.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michael_dawson
Port to PPC
5 years, 9 months ago (2015-03-19 13:52:28 UTC) #1
MTBrandyberry
On 2015/03/19 13:52:28, michael_dawson wrote: > Port to PPC lgtm
5 years, 9 months ago (2015-03-19 15:51:49 UTC) #2
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-23 20:14:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016333002/1
5 years, 9 months ago (2015-03-23 21:02:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 21:32:51 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:33:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/890c0eac21919a08ae10782ec3cc40d1381cbd8b
Cr-Commit-Position: refs/heads/master@{#27381}

Powered by Google App Engine
This is Rietveld 408576698