Move RevokeCredentialsOnServer to MutableProfileOAuth2TokenService

Move RevokeCredentialsOnServer to MutableProfileOAuth2TokenService

This CL moves RevokeCredentialsOnServer and GetRequestContext from
ProfileOAuth2TokenService to MutableProfileOAuth2TokenService.

BUG=320625
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242113

[msarda, 2013-12-19 10:28:29]

Please take a look.

[Roger Tawa OOO till Jul 10th, 2013-12-19 13:43:58]

lgtm, one comment below.

https://codereview.chromium.org/101633009/diff/1/chrome/browser/signin/mutabl...
File chrome/browser/signin/mutable_profile_oauth2_token_service.cc (right):

https://codereview.chromium.org/101633009/diff/1/chrome/browser/signin/mutabl...
chrome/browser/signin/mutable_profile_oauth2_token_service.cc:54:
scoped_ptr<GaiaAuthFetcher> fetcher_;
While you're here, can you change this member from:

   scoped_ptr<GaiaAuthFetcher> fetcher_;

to:

   GaiaAuthFetcher fetcher_;

I think its simpler and reduces the number of separate memory allocations.

[msarda, 2013-12-19 17:35:35]

https://chromiumcodereview.appspot.com/101633009/diff/1/chrome/browser/signin...
File chrome/browser/signin/mutable_profile_oauth2_token_service.cc (right):

https://chromiumcodereview.appspot.com/101633009/diff/1/chrome/browser/signin...
chrome/browser/signin/mutable_profile_oauth2_token_service.cc:54:
scoped_ptr<GaiaAuthFetcher> fetcher_;
On 2013/12/19 13:43:58, Roger Tawa wrote:
> While you're here, can you change this member from:
> 
>    scoped_ptr<GaiaAuthFetcher> fetcher_;
> 
> to:
> 
>    GaiaAuthFetcher fetcher_;
> 
> I think its simpler and reduces the number of separate memory allocations.

Done.

If GaiaAuthFetcher had used a ref counted pointer to
net::URLRequestContextGetter, then we could remove |request_context_| as well. I
don't actually know why GaiaAuthFetcher doesn't use a scoped_refptr for its
request context getter.

That is a larger refactoring though, I won't do it in this CL.

[Roger Tawa OOO till Jul 10th, 2013-12-19 19:23:47]

On 2013/12/19 17:35:35, msarda wrote:
>
https://chromiumcodereview.appspot.com/101633009/diff/1/chrome/browser/signin...
> File chrome/browser/signin/mutable_profile_oauth2_token_service.cc (right):
> 
>
https://chromiumcodereview.appspot.com/101633009/diff/1/chrome/browser/signin...
> chrome/browser/signin/mutable_profile_oauth2_token_service.cc:54:
> scoped_ptr<GaiaAuthFetcher> fetcher_;
> On 2013/12/19 13:43:58, Roger Tawa wrote:
> > While you're here, can you change this member from:
> > 
> >    scoped_ptr<GaiaAuthFetcher> fetcher_;
> > 
> > to:
> > 
> >    GaiaAuthFetcher fetcher_;
> > 
> > I think its simpler and reduces the number of separate memory allocations.
> 
> Done.
> 
> If GaiaAuthFetcher had used a ref counted pointer to
> net::URLRequestContextGetter, then we could remove |request_context_| as well.
I
> don't actually know why GaiaAuthFetcher doesn't use a scoped_refptr for its
> request context getter.
> 
> That is a larger refactoring though, I won't do it in this CL.

Yes good point.  A separate CL sounds right.

[commit-bot: I haz the power, 2013-12-20 07:20:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/101633009/20001

[commit-bot: I haz the power, 2013-12-20 08:41:29]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-20 08:45:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/101633009/20001

[commit-bot: I haz the power, 2013-12-20 17:35:25]

Change committed as 242113