Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1016323002: Revert of Cleanup and unify Isolate::ReportPendingMessages. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_stack-handler-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Cleanup and unify Isolate::ReportPendingMessages. (patchset #4 id:60001 of https://codereview.chromium.org/999923004/) Reason for revert: Failing Blink tests on Win and Mac: - plugins/netscape-plugin-property-access-exception.html - http/tests/plugins/cross-frame-object-access.html Original issue's description: > Cleanup and unify Isolate::ReportPendingMessages. > > Note that this is a pure cleanup CL and shouldn't have an observable > impact on the functional behavior of message reporting. > > R=yangguo@chromium.org TBR=yangguo@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0819ed9f33c1d74addd74b71b548032aa4dd5eaa Cr-Commit-Position: refs/heads/master@{#27306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -43 lines) Patch
M src/isolate.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/isolate.cc View 4 chunks +55 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
Created Revert of Cleanup and unify Isolate::ReportPendingMessages.
5 years, 9 months ago (2015-03-19 13:22:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016323002/1
5 years, 9 months ago (2015-03-19 13:22:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:22:48 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:23:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0819ed9f33c1d74addd74b71b548032aa4dd5eaa
Cr-Commit-Position: refs/heads/master@{#27306}

Powered by Google App Engine
This is Rietveld 408576698