Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1016293002: Revert of Return the accessible selection bounds in password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 664
665 return false; 665 return false;
666 } 666 }
667 667
668 bool AXNodeObject::isPasswordField() const 668 bool AXNodeObject::isPasswordField() const
669 { 669 {
670 Node* node = this->node(); 670 Node* node = this->node();
671 if (!isHTMLInputElement(node)) 671 if (!isHTMLInputElement(node))
672 return false; 672 return false;
673 673
674 AccessibilityRole ariaRole = ariaRoleAttribute(); 674 if (ariaRoleAttribute() != UnknownRole)
675 if (ariaRole != TextFieldRole && ariaRole != TextAreaRole)
676 return false; 675 return false;
677 676
678 return toHTMLInputElement(node)->type() == InputTypeNames::password; 677 return toHTMLInputElement(node)->type() == InputTypeNames::password;
679 } 678 }
680 679
681 bool AXNodeObject::isProgressIndicator() const 680 bool AXNodeObject::isProgressIndicator() const
682 { 681 {
683 return roleValue() == ProgressIndicatorRole; 682 return roleValue() == ProgressIndicatorRole;
684 } 683 }
685 684
(...skipping 1307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1993 float range = maxValueForRange() - minValueForRange(); 1992 float range = maxValueForRange() - minValueForRange();
1994 float value = valueForRange(); 1993 float value = valueForRange();
1995 1994
1996 value += range * (percentChange / 100); 1995 value += range * (percentChange / 100);
1997 setValue(String::number(value)); 1996 setValue(String::number(value));
1998 1997
1999 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true); 1998 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
2000 } 1999 }
2001 2000
2002 } // namespace blink 2001 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698