Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1016293002: Revert of Return the accessible selection bounds in password fields. (Closed)

Created:
5 years, 9 months ago by pfeldman
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Return the accessible selection bounds in password fields. (patchset #2 id:20001 of https://codereview.chromium.org/1009543009/) Reason for revert: Fails tests, prevents roll: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/39363 Original issue's description: > Return the accessible selection bounds in password fields. > > There's no reason not to return it. This code was originally > added to WebKit to mimic the behavior of other Mac fields, but > it seems to work fine without it. > > While we're at it, make sure that role=textbox is exposed as > a password field, too. > > BUG=84250 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192125 TBR=aboxhall@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=84250 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -43 lines) Patch
D LayoutTests/accessibility/input-type-password-selection.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/accessibility/input-type-password-selection-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Return the accessible selection bounds in password fields.
5 years, 9 months ago (2015-03-19 09:18:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016293002/1
5 years, 9 months ago (2015-03-19 09:19:21 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 09:20:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192145

Powered by Google App Engine
This is Rietveld 408576698