PPAPI idl parser was missing error handler

PPAPI idl parser was missing error handler

YACC parser used by PPAPI idl parser needs error function for each keyword to handle error.
Due to missing error function for dictionary object, yacc parser was deleting all data in
the stack including start of the file and when it restarts and reach end of file, since start
of file is missing it goes in endless loop.

R=noelallen@chromium.org,sehr@chromoium.org,nbarth@chromium.org
BUG=320921
TEST=Add new dictionary object in idl file with missing semicolon, compilation will fail.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239965

[Habib Virji, 2013-12-06 09:58:34]

With the proposed patch error is generated error during compilation of idl.

Following error is generated during media_galleries.idl compilation with error
specified in the bug.

RULE Generating C++ code from media_galleries.idl IDL files
media_galleries.idl(57) : Error : Unexpected "}" after symbol baz.
ACTION Generating C++ API bundle code
media_galleries.idl(57) : Error : Unexpected "}" after symbol baz.

[noelallen_use_chromium, 2013-12-07 00:31:17]

Hmmm, there should be an accompanying test in       
  ppapi/generators/test_parser/dictionary.idl

You could just add the file, and put in a test for the change you made:
/* FAIL Dictionary missing name. */
struct {
  PP_Bool Mem1;
  PP_Resource Mem2;
};

(the parsing should pretty much match struct.idl) in the same dir.


Otherwise, the dictionary is unused by PPAPI, so the next place to look for a
test would be in the in tools/json_schema_compiler.  But I'm not familiar that
side of it unfortunately.

[Habib Virji, 2013-12-07 10:09:42]

Thanks for reviewing will add tests on ppapi side and investigate adding tests
in json schema side.

 On 2013/12/07 00:31:17, noelallen wrote:
> Hmmm, there should be an accompanying test in       
>   ppapi/generators/test_parser/dictionary.idl
> 
> You could just add the file, and put in a test for the change you made:
> /* FAIL Dictionary missing name. */
> struct {
>   PP_Bool Mem1;
>   PP_Resource Mem2;
> };
> 
> (the parsing should pretty much match struct.idl) in the same dir.
> 
> 
> Otherwise, the dictionary is unused by PPAPI, so the next place to look for a
> test would be in the in tools/json_schema_compiler.  But I'm not familiar that
> side of it unfortunately.

[Nils Barth (inactive), 2013-12-09 01:34:05]

Thanks Habib!
Looks like you've correctly diagnosed the problem,
and fix looks fine, pending tests (per Noel).

Thanks for taking this up; I had been very puzzled by this,
but hadn't had cycles to look at it.

[Habib Virji, 2013-12-09 11:18:07]

On 2013/12/07 00:31:17, noelallen wrote:
> Hmmm, there should be an accompanying test in       
>   ppapi/generators/test_parser/dictionary.idl
> 
> You could just add the file, and put in a test for the change you made:
> /* FAIL Dictionary missing name. */
> struct {
>   PP_Bool Mem1;
>   PP_Resource Mem2;
> };
> 
> (the parsing should pretty much match struct.idl) in the same dir.
> 
> 
> Otherwise, the dictionary is unused by PPAPI, so the next place to look for a
> test would be in the in tools/json_schema_compiler.  But I'm not familiar that
> side of it unfortunately.

Added dictionary.idl as suggested with one pass test and a test that will
generate error.

Please suggest if I should look adding test in json_schema_compiler. In general,
json schema
compiler does not seem to include tests that could fail or generate error.

[Habib Virji, 2013-12-09 11:20:02]

On 2013/12/09 01:34:05, Nils Barth wrote:
> Thanks Habib!
> Looks like you've correctly diagnosed the problem,
> and fix looks fine, pending tests (per Noel).
> 
> Thanks for taking this up; I had been very puzzled by this,
> but hadn't had cycles to look at it.

Thanks Nils for reviewing code. I have added tests as suggested.

[noelallen1, 2013-12-09 17:45:34]

Great, thanks very much!
LGTM

[Habib Virji, 2013-12-10 09:54:26]

On 2013/12/09 17:45:34, noelallen1 wrote:
> Great, thanks very much!
> LGTM

Thanks Noel, can you please commit my changes, I do not have commit rights.

[commit-bot: I haz the power, 2013-12-10 23:53:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/101623003/20001

[commit-bot: I haz the power, 2013-12-11 02:25:42]

Change committed as 239965