LayoutTests/transitions/resources/opacity-transform-transitions-inside-iframe-inner.html - Issue 101623002: Drop "only composite opacity animations when already in compositing mode".

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/transitions/resources/opacity-transform-transitions-inside-iframe-inner.html

Issue 101623002: Drop "only composite opacity animations when already in compositing mode". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use internals.forceCompositingUpdate instead of setTimeout Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/transitions/opacity-transform-transitions-inside-iframe-expected.txt ('k') | Source/core/animation/ActiveAnimations.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE>

	2 <html>

	3 <head>

	4 <style>

	5 #background {

	6 width: 200px;

	7 height: 200px;

	8 display: block;

	9 background-color: green;

	10 }

	11 .overlay {

	12 width: 50px;

	13 height: 50px;

	14 background-color: rgba(255, 255, 255, 1);

	15 -webkit-transition: opacity 1s;

	16 }

	17

	18 #popup {

	19 width: 20px;

	20 height: 20px;

	21 background-color: red;

	22 border-radius: 6px;

	23 -webkit-transition: -webkit-transform 1s;

	24 }

	25

	26 .transparent {

	27 opacity: 0;

	28 }

	29

	30 [hidden] {

	31 display: none;

	32 }

	33

	34 .overlay.transparent .page {

	35 -webkit-transform: scale(1) translateY(0px);

	36 }

	37

	38 </style>

	39 <script type="text/javascript" charset="utf-8">

	40 function runTest()

	41 {

	42 var solid_color_overlay = document.getElementById("solid_color_overlay") ;

	43 solid_color_overlay.removeAttribute('hidden');

	44

	45 var popup = document.getElementById("popup");

	46 popup.removeAttribute('hidden');

	47

	48 // NOTE: This is a hacky way to force the container to layout which

	49 // will allow us to trigger the webkit transition.

	50 // See crbug.com/324685

	51 solid_color_overlay.scrollTop;

	52 solid_color_overlay.classList.remove('transparent');

	53

	54 // dump the pixel in the middle of the transition

	55 window.internals.forceCompositingUpdate(document);

	56 window.internals.pauseAnimations(0.5);

	57 window.setTimeout(function() {

	58 triggerPixelResults();

	59 }, 0.5);
	ajuma 2013/12/03 16:30:37 Can we do without this setTimeout? (I'm trying to Can we do without this setTimeout? (I'm trying to understand where the 0.5 is coming from here.) dshwang 2013/12/03 16:50:22 Thank you. setTimeout is not needed in here as wel Show quoted text On 2013/12/03 16:30:37, ajuma wrote: > Can we do without this setTimeout? (I'm trying to understand where the 0.5 is > coming from here.) Thank you. setTimeout is not needed in here as well as transitions/opacity-transition-zindex.html I updated. I misunderstood what pauseAnimations() is. I thought pauseAnimations() means to start and then stop at the given time. I know now pauseAnimations() means to seek at the given time.
	60 }

	61

	62 function triggerPixelResults()

	63 {

	64 parent.postMessage("TriggerPixelResults", '*');

	65 }

	66

	67 window.addEventListener('load', runTest, false);

	68 </script>

	69 </head>

	70 <body>

	71 <div id="background">

	72 <div id="solid_color_overlay" class="overlay transparent" hidden=true>

	73 <div id="popup" class="page" hidden=true></div>

	74 </div>

	75 </div>

	76 </body>

	77 </html>

OLD	NEW