gpu: Use GetUniformSetup computed result size.

gpu: Use GetUniformSetup computed result size.

R=piman@chromium.org
BUG=468936
Committed: https://crrev.com/181c7400b2bf50ba02ac77149749fb419b4d4797
Cr-Commit-Position: refs/heads/master@{#321489}

[vmiura, 2015-03-19 22:23:55]

PTAL

[vmiura, 2015-03-19 22:36:38]

vmiura@chromium.org changed reviewers:
+ inferno@chromium.org

[vmiura, 2015-03-19 22:36:38]

PTAL

[inferno, 2015-03-19 22:43:21]

inferno@chromium.org changed reviewers:
+ jln@chromium.org, rickyz@chromium.org

[inferno, 2015-03-19 22:57:11]

lgtm

[piman, 2015-03-19 23:00:06]

lgtm

https://codereview.chromium.org/1016193003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1016193003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9717: GLsizei num_values =
result_size / sizeof(GLfloat);
nit: result_size / sizeof(Result::Type);

[vmiura, 2015-03-19 23:14:58]

The CQ bit was checked by vmiura@chromium.org

[vmiura, 2015-03-19 23:14:59]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/1016193003/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2015-03-19 23:15:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1016193003/20001

[commit-bot: I haz the power, 2015-03-20 01:32:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 01:33:45]

Patchset 2 (id:??) landed as
https://crrev.com/181c7400b2bf50ba02ac77149749fb419b4d4797
Cr-Commit-Position: refs/heads/master@{#321489}

[Tom Sepez, 2015-03-20 22:09:17]

tsepez@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-03-20 22:09:17]

https://codereview.chromium.org/1016193003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1016193003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9713:
reinterpret_cast<void**>(&result), &result_type,
nit: (Super-nit actually) The reinterpret_cast here isn't strictly legal because
there's no reason to believe that a struct pointer and a void pointer have the
same representations (although any platform where that was the case is long
extinct).  You can erase any doubt along wiht the need for reinterpret if you
did something like:

void* result_void;
Result* result;
...GetUniformSetup(..., &result_void, ...) ...
result = static_cast<Result*>(result_void);