Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1016193003: gpu: Use GetUniformSetup computed result size. (Closed)

Created:
4 years, 4 months ago by vmiura
Modified:
4 years, 4 months ago
CC:
piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Use GetUniformSetup computed result size. R=piman@chromium.org BUG=468936 Committed: https://crrev.com/181c7400b2bf50ba02ac77149749fb419b4d4797 Cr-Commit-Position: refs/heads/master@{#321489}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 5 chunks +31 lines, -18 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
vmiura
PTAL
4 years, 4 months ago (2015-03-19 22:23:55 UTC) #1
vmiura
PTAL
4 years, 4 months ago (2015-03-19 22:36:38 UTC) #3
inferno
lgtm
4 years, 4 months ago (2015-03-19 22:57:11 UTC) #5
piman
lgtm https://codereview.chromium.org/1016193003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1016193003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode9717 gpu/command_buffer/service/gles2_cmd_decoder.cc:9717: GLsizei num_values = result_size / sizeof(GLfloat); nit: result_size ...
4 years, 4 months ago (2015-03-19 23:00:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016193003/20001
4 years, 4 months ago (2015-03-19 23:15:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2015-03-20 01:32:57 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/181c7400b2bf50ba02ac77149749fb419b4d4797 Cr-Commit-Position: refs/heads/master@{#321489}
4 years, 4 months ago (2015-03-20 01:33:45 UTC) #11
Tom Sepez
4 years, 4 months ago (2015-03-20 22:09:17 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1016193003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1016193003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9713:
reinterpret_cast<void**>(&result), &result_type,
nit: (Super-nit actually) The reinterpret_cast here isn't strictly legal because
there's no reason to believe that a struct pointer and a void pointer have the
same representations (although any platform where that was the case is long
extinct).  You can erase any doubt along wiht the need for reinterpret if you
did something like:

void* result_void;
Result* result;
...GetUniformSetup(..., &result_void, ...) ...
result = static_cast<Result*>(result_void);

Powered by Google App Engine
This is Rietveld 408576698