Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1016183002: Revert of Store the callstack of the IPC sender of ViewMsg_New (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 88c7bd484e73f951f3597186b903a13e85e4cf77..d411147589e6a4a92c1f6315ee13c27ff4c00e2d 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -676,32 +676,7 @@ RenderFrameImpl::RenderFrameImpl(RenderViewImpl* render_view, int routing_id)
weak_factory_(this) {
std::pair<RoutingIDFrameMap::iterator, bool> result =
g_routing_id_frame_map.Get().insert(std::make_pair(routing_id_, this));
- if (!result.second) {
- // TODO(lfg): Temporary. We're about to force a crash, so save the debug
- // info on the stack so we can recover it from the crash dumps.
- RenderFrameImpl* duplicate = result.first->second;
- const std::vector<unsigned long>& debug_info = render_view->debug_info();
- const std::vector<unsigned long>& duplicate_debug_info =
- duplicate->render_view()->debug_info();
- unsigned long duplicate_stack_debug_info[128];
- unsigned long stack_debug_info[128];
- const int size = debug_info.size() > 128 ? 128 : debug_info.size();
- const int duplicate_size =
- duplicate_debug_info.size() > 128 ? 128 : duplicate_debug_info.size();
- for (int i = 0; i < size; i++)
- stack_debug_info[i] = debug_info[i];
- for (int i = 0; i < duplicate_size; i++)
- duplicate_stack_debug_info[i] = duplicate_debug_info[i];
- CHECK(result.second) << "Inserting a duplicate item.";
- // Make sure the variable is stored on the stack and use it so that the
- // compiler won't optimize it out.
- base::debug::Alias(&stack_debug_info);
- base::debug::Alias(&duplicate_stack_debug_info);
- for (int i = 0; i < size; i++)
- LOG(ERROR) << stack_debug_info[i];
- for (int i = 0; i < duplicate_size; i++)
- LOG(ERROR) << duplicate_stack_debug_info[i];
- }
+ CHECK(result.second) << "Inserting a duplicate item.";
RenderThread::Get()->AddRoute(routing_id_, this);
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698