Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: ash/shell.cc

Issue 1016173002: Revert of Fix for menus blocking user activity detection (Retry). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/shell/browser/shell_desktop_controller_aura.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell.h" 5 #include "ash/shell.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "ash/accelerators/accelerator_controller.h" 10 #include "ash/accelerators/accelerator_controller.h"
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
671 // Please keep in same order as in Init() because it's easy to miss one. 671 // Please keep in same order as in Init() because it's easy to miss one.
672 if (window_modality_controller_) 672 if (window_modality_controller_)
673 window_modality_controller_.reset(); 673 window_modality_controller_.reset();
674 #if defined(OS_CHROMEOS) 674 #if defined(OS_CHROMEOS)
675 RemovePreTargetHandler(magnifier_key_scroll_handler_.get()); 675 RemovePreTargetHandler(magnifier_key_scroll_handler_.get());
676 magnifier_key_scroll_handler_.reset(); 676 magnifier_key_scroll_handler_.reset();
677 677
678 RemovePreTargetHandler(speech_feedback_handler_.get()); 678 RemovePreTargetHandler(speech_feedback_handler_.get());
679 speech_feedback_handler_.reset(); 679 speech_feedback_handler_.reset();
680 #endif 680 #endif
681 RemovePreTargetHandler(user_activity_detector_.get());
681 RemovePreTargetHandler(overlay_filter_.get()); 682 RemovePreTargetHandler(overlay_filter_.get());
682 RemovePreTargetHandler(input_method_filter_.get()); 683 RemovePreTargetHandler(input_method_filter_.get());
683 RemovePreTargetHandler(accelerator_filter_.get()); 684 RemovePreTargetHandler(accelerator_filter_.get());
684 RemovePreTargetHandler(event_transformation_handler_.get()); 685 RemovePreTargetHandler(event_transformation_handler_.get());
685 RemovePreTargetHandler(toplevel_window_event_handler_.get()); 686 RemovePreTargetHandler(toplevel_window_event_handler_.get());
686 RemovePostTargetHandler(toplevel_window_event_handler_.get()); 687 RemovePostTargetHandler(toplevel_window_event_handler_.get());
687 RemovePreTargetHandler(system_gesture_filter_.get()); 688 RemovePreTargetHandler(system_gesture_filter_.get());
688 RemovePreTargetHandler(keyboard_metrics_filter_.get()); 689 RemovePreTargetHandler(keyboard_metrics_filter_.get());
689 RemovePreTargetHandler(mouse_cursor_filter_.get()); 690 RemovePreTargetHandler(mouse_cursor_filter_.get());
690 691
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 AddPreTargetHandler(magnifier_key_scroll_handler_.get()); 915 AddPreTargetHandler(magnifier_key_scroll_handler_.get());
915 speech_feedback_handler_ = SpokenFeedbackToggler::CreateHandler(); 916 speech_feedback_handler_ = SpokenFeedbackToggler::CreateHandler();
916 AddPreTargetHandler(speech_feedback_handler_.get()); 917 AddPreTargetHandler(speech_feedback_handler_.get());
917 #endif 918 #endif
918 919
919 // The order in which event filters are added is significant. 920 // The order in which event filters are added is significant.
920 921
921 // ui::UserActivityDetector passes events to observers, so let them get 922 // ui::UserActivityDetector passes events to observers, so let them get
922 // rewritten first. 923 // rewritten first.
923 user_activity_detector_.reset(new ui::UserActivityDetector); 924 user_activity_detector_.reset(new ui::UserActivityDetector);
925 AddPreTargetHandler(user_activity_detector_.get());
924 926
925 overlay_filter_.reset(new OverlayEventFilter); 927 overlay_filter_.reset(new OverlayEventFilter);
926 AddPreTargetHandler(overlay_filter_.get()); 928 AddPreTargetHandler(overlay_filter_.get());
927 AddShellObserver(overlay_filter_.get()); 929 AddShellObserver(overlay_filter_.get());
928 930
929 input_method_filter_.reset(new ::wm::InputMethodEventFilter( 931 input_method_filter_.reset(new ::wm::InputMethodEventFilter(
930 root_window->GetHost()->GetAcceleratedWidget())); 932 root_window->GetHost()->GetAcceleratedWidget()));
931 AddPreTargetHandler(input_method_filter_.get()); 933 AddPreTargetHandler(input_method_filter_.get());
932 934
933 accelerator_filter_.reset(new ::wm::AcceleratorFilter( 935 accelerator_filter_.reset(new ::wm::AcceleratorFilter(
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
1168 //////////////////////////////////////////////////////////////////////////////// 1170 ////////////////////////////////////////////////////////////////////////////////
1169 // Shell, aura::client::ActivationChangeObserver implementation: 1171 // Shell, aura::client::ActivationChangeObserver implementation:
1170 1172
1171 void Shell::OnWindowActivated(aura::Window* gained_active, 1173 void Shell::OnWindowActivated(aura::Window* gained_active,
1172 aura::Window* lost_active) { 1174 aura::Window* lost_active) {
1173 if (gained_active) 1175 if (gained_active)
1174 target_root_window_ = gained_active->GetRootWindow(); 1176 target_root_window_ = gained_active->GetRootWindow();
1175 } 1177 }
1176 1178
1177 } // namespace ash 1179 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | extensions/shell/browser/shell_desktop_controller_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698