Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2279)

Issue 1016143002: Update deploy and deploy_sdk for the new package: world. (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update deploy and deploy_sdk for the new package: world. Before this change Sky would hit 404s when trying to load examples from domokit.github.io. I also added a separate sky_home and updated the default url to point to sky_home instead of home. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8f0ad77247ddeb51a35855d2e4e5efeed82f5f31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M mojo/tools/deploy.py View 2 chunks +12 lines, -1 line 0 comments Download
M sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/deploy_sdk.py View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-18 19:54:14 UTC) #1
eseidel
5 years, 9 months ago (2015-03-18 20:00:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f0ad77247ddeb51a35855d2e4e5efeed82f5f31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698