Issue 101613002: Android: some minor improvements to jni_generator_tests.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101613002: Android: some minor improvements to jni_generator_tests.py (Closed)

Created:
7 years ago by bulach

Modified:
7 years ago

Reviewers:
nadiapayet, dawalker, Sami, davewalker

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Android: some minor improvements to jni_generator_tests.py Addresses some comments to jni_generator_tests.py. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238785

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	base/android/jni_generator/jni_generator_tests.py	View		2 chunks	+14 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

nadiapayet

On 2013/12/03 11:12:31, Sami wrote: > Thanks, this makes some of the magic more obvious. ...

7 years ago (2013-12-04 17:11:00 UTC) #3

dawalker

On 2013/12/04 17:11:00, nadiapayet wrote: > On 2013/12/03 11:12:31, Sami wrote: > > Thanks, this ...

7 years ago (2013-12-04 19:04:32 UTC) #4

bulach

yay, thanks folks! :) will land this, then copy over to the internal repository, then ...

7 years ago (2013-12-04 19:20:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/101613002/1

7 years ago (2013-12-04 19:20:39 UTC) #6

Message was sent while issue was closed.

Change committed as 238785