Issue 1016103004: Revert of Revert of remove colorfilter native-565 support. complicating w/ no real value.

Issue 1016103004: Revert of Revert of remove colorfilter native-565 support. complicating w/ no real value. (Closed)

Created:
5 years, 9 months ago by reed1

Modified:
5 years, 9 months ago

Reviewers:
reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #1 id:1 of https://codereview.chromium.org/1022673007/) Reason for revert: fix for chrome has landed... Original issue's description: > Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/) > > Reason for revert: > skia/ext/benchmarking_canvas.cc references HasFilter16 :( > > Original issue's description: > > remove colorfilter native-565 support. complicating w/ no real value. > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710 > > TBR=reed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/92b47c49016749249ff8521e424c4373b4a74241 TBR=reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/62a320c8d444cd04e4f2952c269ea4cbd58dee64

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -136 lines)			Patch
M	include/core/SkColorFilter.h	View	1 chunk	+3 lines, -19 lines	0 comments	Download
M	include/effects/SkColorMatrixFilter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/effects/SkModeColorFilter.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/core/SkColorFilter.cpp	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/core/SkFilterShader.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkFilterShader.cpp	View	2 chunks	+4 lines, -15 lines	0 comments	Download
M	src/effects/SkColorFilters.cpp	View	5 chunks	+10 lines, -44 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	3 chunks	+1 line, -38 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of Revert of remove colorfilter native-565 support. complicating w/ no real value.

5 years, 9 months ago (2015-03-24 13:35:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016103004/1

5 years, 9 months ago (2015-03-24 13:35:13 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-24 13:35:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/62a320c8d444cd04e4f2952c269ea4cbd58dee64