Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1016093002: Begin work on the PopupMenu entrance animation (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Begin work on the PopupMenu entrance animation This CL also refactors how animations work, particularly for the Drawer. I've renamed DrawerAnimation to DrawerController and switched it from being an Animation to having an Animation. I've also renamed Animation to AnimatedValue to capture the idea that the class actually presents the value being animated. Finally, I've factored AnimatedValueListener out of Drawer so that it can be used by PopupMenuItem as well. Finally, I've added a scheduleBuild convienence function to Component instead of having to call setState(() {}), which has come up a couple times. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c7d69836909bcd4c0b4beb4a2f71ac7164511104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -114 lines) Patch
M sky/examples/stocks-fn/lib/stock_app.dart View 4 chunks +10 lines, -5 lines 0 comments Download
A + sky/framework/animation/animated_value.dart View 3 chunks +35 lines, -7 lines 0 comments Download
D sky/framework/animation/animation.dart View 1 chunk +0 lines, -54 lines 0 comments Download
M sky/framework/components/drawer.dart View 5 chunks +31 lines, -44 lines 0 comments Download
M sky/framework/components/input.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/popup_menu.dart View 2 chunks +24 lines, -2 lines 0 comments Download
M sky/framework/components/popup_menu_item.dart View 2 chunks +12 lines, -1 line 0 comments Download
M sky/framework/fn.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 9 months ago (2015-03-18 17:59:47 UTC) #1
rafaelw
lgtm
5 years, 9 months ago (2015-03-18 18:28:42 UTC) #3
eseidel
lgtm
5 years, 9 months ago (2015-03-18 18:30:24 UTC) #5
abarth-chromium
5 years, 9 months ago (2015-03-18 18:31:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7d69836909bcd4c0b4beb4a2f71ac7164511104 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698