Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1016073002: [arm64] Assembler support for internal references. (Closed)

Created:
5 years, 9 months ago by Rodolph Perfetta (ARM)
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Assembler support for internal references. BUG= Committed: https://crrev.com/abf78583b9e37dc072878131c329813da0d887c2 Cr-Commit-Position: refs/heads/master@{#27296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -8 lines) Patch
M src/arm64/assembler-arm64.h View 3 chunks +8 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 6 chunks +62 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/arm64/instructions-arm64.h View 5 chunks +36 lines, -5 lines 0 comments Download
M src/arm64/instructions-arm64.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +170 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Rodolph Perfetta (ARM)
I'll update the switch implementation in a follow up patch.
5 years, 9 months ago (2015-03-18 16:42:59 UTC) #2
Benedikt Meurer
LGTM
5 years, 9 months ago (2015-03-19 05:10:26 UTC) #4
Yang
On 2015/03/19 05:10:26, Benedikt Meurer wrote: > LGTM LGTM. Please consider porting https://codereview.chromium.org/1005183006/
5 years, 9 months ago (2015-03-19 07:22:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016073002/1
5 years, 9 months ago (2015-03-19 10:06:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 10:24:53 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:25:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abf78583b9e37dc072878131c329813da0d887c2
Cr-Commit-Position: refs/heads/master@{#27296}

Powered by Google App Engine
This is Rietveld 408576698