Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

Issue 1016033011: omnibox: Don't paint children from inside OnPaint(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: omnibox: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
index 855135c4ecef84aebcc9e4b0314dc40e471dbcb9..e655ffa5591dfdaa834417ffec8e652c0f8e556d 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
@@ -81,8 +81,6 @@ class OmniboxPopupContentsView : public views::View,
LocationBarView* location_bar_view() { return location_bar_view_; }
- virtual void PaintResultViews(gfx::Canvas* canvas);
-
// Calculates the height needed to show all the results in the model.
virtual int CalculatePopupHeight();
virtual OmniboxResultView* CreateResultView(int model_index,
@@ -94,10 +92,6 @@ class OmniboxPopupContentsView : public views::View,
// views::View:
const char* GetClassName() const override;
void OnPaint(gfx::Canvas* canvas) override;
- // This method should not be triggered directly as we paint our children
- // in an un-conventional way inside OnPaint. We use a separate canvas to
- // paint the children. Hence we override this method to a no-op so that
- // the view hierarchy does not "accidentally" trigger this.
void PaintChildren(gfx::Canvas* canvas,
const views::CullSet& cull_set) override;
@@ -113,10 +107,6 @@ class OmniboxPopupContentsView : public views::View,
// Returns the match at the specified index within the popup model.
const AutocompleteMatch& GetMatchAtIndex(size_t index) const;
- // Fill a path for the contents' roundrect. |bounding_rect| is the rect that
- // bounds the path.
- void MakeContentsPath(gfx::Path* path, const gfx::Rect& bounding_rect);
-
// Find the index of the match under the given |point|, specified in window
// coordinates. Returns OmniboxPopupModel::kNoMatch if there isn't a match at
// the specified point.
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698