Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

Issue 1016033011: omnibox: Don't paint children from inside OnPaint(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
index 855135c4ecef84aebcc9e4b0314dc40e471dbcb9..123e756908622355bdc6dce490b5f49b348a03f9 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
@@ -93,11 +93,6 @@ class OmniboxPopupContentsView : public views::View,
// views::View:
const char* GetClassName() const override;
- void OnPaint(gfx::Canvas* canvas) override;
- // This method should not be triggered directly as we paint our children
- // in an un-conventional way inside OnPaint. We use a separate canvas to
- // paint the children. Hence we override this method to a no-op so that
- // the view hierarchy does not "accidentally" trigger this.
void PaintChildren(gfx::Canvas* canvas,
const views::CullSet& cull_set) override;

Powered by Google App Engine
This is Rietveld 408576698