Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 1016033010: Fix WebViewTest.TestContextMenu on official builders. (Closed)

Created:
5 years, 9 months ago by lazyboy
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebViewTest.TestContextMenu on official builders. We stopped showing "Inspect Element" on dev/beta/stable, therefore TestContextMenu does not seem to find any menu item when right-click is performed. This CL makes sure we always have an <input> on the right-click target so that we have some items to show in the context menu. BUG=470300 Test=None, internal test only change. Committed: https://crrev.com/2a65624aa3d60e2b5a13a8dff8862c07f2d422ad Cr-Commit-Position: refs/heads/master@{#322326}

Patch Set 1 #

Patch Set 2 : Trybot only change, do not review this one #

Patch Set 3 : revert trybot change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/test/data/extensions/platform_apps/web_view/context_menus/basic/guest.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
Waiting for the trybots to see if this fix is enough or it has some ...
5 years, 9 months ago (2015-03-26 00:40:51 UTC) #2
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-26 02:37:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016033010/40001
5 years, 9 months ago (2015-03-26 03:25:26 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-26 05:23:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 05:23:33 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a65624aa3d60e2b5a13a8dff8862c07f2d422ad
Cr-Commit-Position: refs/heads/master@{#322326}

Powered by Google App Engine
This is Rietveld 408576698