Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1016033009: Add RealPanWalletClient unittest. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rouslan+autofillwatch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add RealPanWalletClient unittest. Also change some logging to VLOG. To see logs, use --vmodule="*/autofill/*=2" --enable-logging=stderr BUG=470232 Committed: https://crrev.com/2a205a75fe37209cadf1d66be2590fc0761a61a7 Cr-Commit-Position: refs/heads/master@{#322264}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -3 lines) Patch
A components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc View 1 chunk +154 lines, -0 lines 5 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 9 months ago (2015-03-25 21:46:13 UTC) #2
please use gerrit instead
lgtm % nits https://codereview.chromium.org/1016033009/diff/1/components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc File components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc (right): https://codereview.chromium.org/1016033009/diff/1/components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc#newcode123 components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc:123: EXPECT_EQ("", real_pan_); EXPECT_TRUE(real_pan_.empty()); https://codereview.chromium.org/1016033009/diff/1/components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc#newcode134 components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc:134: EXPECT_EQ("", ...
5 years, 9 months ago (2015-03-25 22:03:12 UTC) #3
Evan Stade
https://codereview.chromium.org/1016033009/diff/1/components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc File components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc (right): https://codereview.chromium.org/1016033009/diff/1/components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc#newcode123 components/autofill/content/browser/wallet/real_pan_wallet_client_unittest.cc:123: EXPECT_EQ("", real_pan_); On 2015/03/25 22:03:12, Rouslan Solomakhin wrote: > ...
5 years, 9 months ago (2015-03-25 22:03:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016033009/1
5 years, 9 months ago (2015-03-25 22:04:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 23:49:46 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 23:50:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2a205a75fe37209cadf1d66be2590fc0761a61a7
Cr-Commit-Position: refs/heads/master@{#322264}

Powered by Google App Engine
This is Rietveld 408576698