Fix implementation of Slow-loading image.

Fix implementation of Slow-loading image.

Blocking on returning the InputStream containing the png caused IPC
processing to stall. On the other hand, blocking on actually reading
from the stream allows IPC messages to be processed in the interim,
resulting in the onPageCommitVisible callback not being intermittently
delayed. This in turn allows us to re-enable the associated test,
which was otherwise flaky.

BUG=467081
Committed: https://crrev.com/a37055409bb8b2e3343916523944da8d4506f535
Cr-Commit-Position: refs/heads/master@{#321134}

[Tobias Sargeant, 2015-03-18 09:33:47]

tobiasjs@chromium.org changed reviewers:
+ mnaganov@google.com

[mnaganov (inactive), 2015-03-18 10:39:55]

mnaganov@chromium.org changed reviewers:
+ mnaganov@chromium.org

[mnaganov (inactive), 2015-03-18 10:39:55]

LGTM % the comment

https://codereview.chromium.org/1015963002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
(right):

https://codereview.chromium.org/1015963002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java:94:
1000));
Is this a timeout? Then please use AwTestBase.WAIT_TIMEOUT_MS.

[Tobias Sargeant, 2015-03-18 11:10:38]

https://codereview.chromium.org/1015963002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
(right):

https://codereview.chromium.org/1015963002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java:94:
1000));
On 2015/03/18 10:39:55, mnaganov (cr) wrote:
> Is this a timeout? Then please use AwTestBase.WAIT_TIMEOUT_MS.

Done.

[Tobias Sargeant, 2015-03-18 11:10:48]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2015-03-18 11:10:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/1015963002/#ps20001
(title: "replace fixed timeout")

[commit-bot: I haz the power, 2015-03-18 11:10:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015963002/20001

[Tobias Sargeant, 2015-03-18 11:50:13]

The CQ bit was unchecked by tobiasjs@chromium.org

[Tobias Sargeant, 2015-03-18 12:06:20]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2015-03-18 12:06:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/1015963002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-03-18 12:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015963002/40001

[Tobias Sargeant, 2015-03-18 12:18:18]

The CQ bit was unchecked by tobiasjs@chromium.org

[boliu, 2015-03-18 14:26:16]

nice

[Tobias Sargeant, 2015-03-18 14:39:41]

tobiasjs@chromium.org changed reviewers:
+ boliu@chromium.org

[Tobias Sargeant, 2015-03-18 14:39:41]

please take another look

[mnaganov (inactive), 2015-03-18 14:41:14]

lgtm

[Tobias Sargeant, 2015-03-18 14:42:29]

The CQ bit was checked by tobiasjs@chromium.org

[commit-bot: I haz the power, 2015-03-18 14:42:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015963002/80001

[commit-bot: I haz the power, 2015-03-18 15:13:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-18 15:13:30]

Patchset 5 (id:??) landed as
https://crrev.com/a37055409bb8b2e3343916523944da8d4506f535
Cr-Commit-Position: refs/heads/master@{#321134}