Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1015953002: [turbofan] Cache Call operator for AllocateHeapNumberStub in change lowering. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cache Call operator for AllocateHeapNumberStub in change lowering. R=svenpanne@chromium.org Committed: https://crrev.com/1f6c284a6c4477c2e58cd15950f044a51875b671 Cr-Commit-Position: refs/heads/master@{#27256}

Patch Set 1 #

Patch Set 2 : AllocateHeapNumber cannot throw. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 1 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-18 07:55:56 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-18 07:56:11 UTC) #2
Sven Panne
lgtm
5 years, 9 months ago (2015-03-18 08:05:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015953002/1
5 years, 9 months ago (2015-03-18 08:05:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015953002/20001
5 years, 9 months ago (2015-03-18 08:08:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 08:45:51 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 08:46:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f6c284a6c4477c2e58cd15950f044a51875b671
Cr-Commit-Position: refs/heads/master@{#27256}

Powered by Google App Engine
This is Rietveld 408576698