Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1015933004: GpuVideoAcceleratorFactories is a pure abstract base class, needs no implementation file. (Closed)

Created:
5 years, 9 months ago by mcasas
Modified:
5 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GpuVideoAcceleratorFactories is a pure abstract base class, needs no implementation file. BUG=440843 Committed: https://crrev.com/0fb120c5bbb9d2b69388aec42795d153e84f6162 Cr-Commit-Position: refs/heads/master@{#321823}

Patch Set 1 : Removed gpu_video_accelerator_factories.cc from media.gyp and media/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/gpu_video_accelerator_factories.h View 1 chunk +1 line, -1 line 0 comments Download
D media/renderers/gpu_video_accelerator_factories.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mcasas
scherkus@ PTAL. This CL, surprisingly, is to the liking of MSVC, unlike the other similar ...
5 years, 9 months ago (2015-03-19 02:36:48 UTC) #4
scherkus (not reviewing)
scherkus -> sandersd to review
5 years, 9 months ago (2015-03-23 17:03:06 UTC) #6
sandersd (OOO until July 31)
lgtm
5 years, 9 months ago (2015-03-23 17:49:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015933004/40001
5 years, 9 months ago (2015-03-23 17:59:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-23 18:54:35 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:55:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fb120c5bbb9d2b69388aec42795d153e84f6162
Cr-Commit-Position: refs/heads/master@{#321823}

Powered by Google App Engine
This is Rietveld 408576698