Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: Source/modules/presentation/PresentationController.cpp

Issue 1015903002: [Presentation API] Adds close method to Presentation session. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/PresentationController.cpp
diff --git a/Source/modules/presentation/PresentationController.cpp b/Source/modules/presentation/PresentationController.cpp
index b5ccfa76bb74b0225a7e1cdb372ea23179f5a159..ca5958707049389895c9c22aacf1b213c4e72bcd 100644
--- a/Source/modules/presentation/PresentationController.cpp
+++ b/Source/modules/presentation/PresentationController.cpp
@@ -104,6 +104,14 @@ void PresentationController::joinSession(const String& presentationUrl, const St
m_client->joinSession(presentationUrl, presentationId, callbacks);
}
+void PresentationController::closeSession(const String& presentationId)
+{
+ if (!m_client) {
whywhat 2015/03/17 23:35:19 nit: remove the curly braces to be consistent with
haibinlu 2015/03/18 00:58:22 Done.
+ return;
+ }
+ m_client->closeSession(presentationId);
whywhat 2015/03/17 23:35:19 high level question: do we want to get any result
haibinlu 2015/03/18 00:58:22 The result of session.close is onstatechange event
whywhat 2015/03/18 12:51:19 Ok, I think this makes sense and aligns with the s
+}
+
void PresentationController::setPresentation(Presentation* presentation)
{
m_presentation = presentation;

Powered by Google App Engine
This is Rietveld 408576698