Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1015853002: Use port 5222 for XMPP connection from Me2Me host (Closed)

Created:
5 years, 9 months ago by Sergey Ulanov
Modified:
5 years, 9 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use port 5222 for XMPP connection from Me2Me host. Connection on port 443 may be redirected through proxy. Proxied connections do not work in the service process (see bug 467960). This is a temporary workaround for that issue. BUG=464044, 467960 Committed: https://crrev.com/0c619881fcd09e4d17b70b11c353b3d5e5af144b Cr-Commit-Position: refs/heads/master@{#321042}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -30 lines) Patch
M remoting/base/service_urls.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/base/service_urls.cc View 1 2 4 chunks +11 lines, -4 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
5 years, 9 months ago (2015-03-17 21:00:12 UTC) #3
rmsousa
lgtm
5 years, 9 months ago (2015-03-17 21:09:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015853002/60001
5 years, 9 months ago (2015-03-18 00:26:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-18 01:16:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 01:17:19 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c619881fcd09e4d17b70b11c353b3d5e5af144b
Cr-Commit-Position: refs/heads/master@{#321042}

Powered by Google App Engine
This is Rietveld 408576698