Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1015833005: Move upstreamed calls to FirstRunActivity. (Closed)

Created:
5 years, 9 months ago by aurimas (slooooooooow)
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move upstreamed calls to FirstRunActivity. BUG=428842 Committed: https://crrev.com/42bf3079fa761103a09099a94c6e3a3216e77155 Cr-Commit-Position: refs/heads/master@{#321893}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Remove log statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 2 5 chunks +17 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aurimas (slooooooooow)
PTAL
5 years, 9 months ago (2015-03-23 17:18:31 UTC) #2
newt (away)
lgtm after comment https://chromiumcodereview.appspot.com/1015833005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java (right): https://chromiumcodereview.appspot.com/1015833005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java#newcode408 chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:408: android.util.Log.i("FirstRunActivity", "onCreate: before native init"); Are ...
5 years, 9 months ago (2015-03-23 17:22:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015833005/40001
5 years, 9 months ago (2015-03-23 22:51:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 23:21:47 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 23:23:08 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/42bf3079fa761103a09099a94c6e3a3216e77155
Cr-Commit-Position: refs/heads/master@{#321893}

Powered by Google App Engine
This is Rietveld 408576698